Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues on Python 3.10 due to six 1.15.0 #78

Open
fpgmaas opened this issue Oct 18, 2023 · 4 comments
Open

Issues on Python 3.10 due to six 1.15.0 #78

fpgmaas opened this issue Oct 18, 2023 · 4 comments

Comments

@fpgmaas
Copy link
Collaborator

fpgmaas commented Oct 18, 2023

importing chispa can cause issues on Python 3.10 due to the use of six 1.15.0. See also secdev/scapy#3502 and this blogpost. As the blogpost patches, the issue is patched in six 1.16.0.

@fpgmaas fpgmaas mentioned this issue Oct 18, 2023
@MrPowers
Copy link
Owner

Thanks for reporting this @fpgmaas.

Looks like we have the six dependency for six.moves.zip_longest.

I'm guessing that we can just add the zip_longest function to this project and get rid of the dependency altogether.

Or should be just be using itertools.zip_longest? Why do we even need six?

@fpgmaas
Copy link
Collaborator Author

fpgmaas commented Oct 18, 2023

Thanks for the quick feedback @MrPowers. I agree with you that seeing if the dependency can be removed altogether is cleaner. I can try to see if we can replace it with itertools.zip_longest and in that case open a PR.

@MrPowers
Copy link
Owner

Yea, six is a Python 2/3 compatibility library. chispa only supports Python >=3.7 now, so hopefully we can get rid of six.

@fpgmaas
Copy link
Collaborator Author

fpgmaas commented Oct 18, 2023

I think I'm able to fix this, however I am running into some issue with running the tests on newer version of Python. The version in .python_version is also a bit outdated. I will create a slightly larger PR that also proposes to drops support for Python 3.7 and updates some of the dev dependencies. Hopefully I have this done by the end of tomorrow :). Will keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants