Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no_dereference context manager suppresses all exceptions on exit #1284

Closed
ikseek opened this issue Apr 25, 2016 · 3 comments
Closed

no_dereference context manager suppresses all exceptions on exit #1284

ikseek opened this issue Apr 25, 2016 · 3 comments
Labels

Comments

@ikseek
Copy link

ikseek commented Apr 25, 2016

no_dereference context manager in it's __exit__ method returns self.cls which is being non-false instructs runtime to ignore the exception according to context manager protocol.
Looks like a copy-pasa.

@lafrech lafrech added the Bug label Apr 25, 2016
@lafrech
Copy link
Member

lafrech commented Apr 25, 2016

Same applies to no_sub_classes.

@bagerard
Copy link
Collaborator

bagerard commented Sep 4, 2018

no_sub_classes got fixed, no_dereference requires more work because some tests are failing. They were previously failing with the AssertionError but they were swallowed by this issue, acting like if the test were passing

@bagerard
Copy link
Collaborator

bagerard commented Aug 20, 2024

closing, got fixed a while ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants