[BUG] Disabled StatefulInteractable are interactable after set SpeechRecognitionKeyword or AllowSelectByVoice

[anonymous2585]

Describe the bug

When setting the properties SpeechRecognitionKeyword or AllowSelectByVoice of a disabled StatefulInteractable, a warning is triggered and the interactable starts again to trigger clicks events even though it's disabled.

This is due to the button unregister and register back to the interaction manager.

To reproduce

Steps to reproduce the behavior:

1. Open the CanvasExample scene
2. Choose one of the "Action Button" and add this script:

using MixedReality.Toolkit;
using System;
using System.Collections;
using System.Collections.Generic;
using UnityEngine;

[RequireComponent(typeof(StatefulInteractable))]
public class VoiceRuntimeChange : MonoBehaviour
{
    private IEnumerator Start()
    {
        StatefulInteractable interactable = GetComponent<StatefulInteractable>();
        interactable.OnClicked.AddListener(OnClicked);
        interactable.enabled = false;
        yield return new WaitForSeconds(1.0f);
        interactable.SpeechRecognitionKeyword = "Hello world"; // trigger a warning and the button is enabled
        yield return new WaitForSeconds(1.0f);
        interactable.AllowSelectByVoice = false; // the button is enabled
    }

    private void OnClicked()
    {
        Debug.Log("Button clicked");
    }
}

4. Press Play
5. Wait 1 second and see the warning
6. Click on the button and see the debug log triggered

Expected behavior

The interactable is doesn't trigger the warning and doesn't trigger click events

Your setup

• Unity Version: 2021.3.21f1
• MRTK Version or Commit: current main branch ec5c141

Target platform

• HoloLens 2
• OpenXR

Additional context

The fix is to check

if (Application.isPlaying && isActiveAndEnabled)

before unregister and register the interactable. This will also fix editor script using these properties.
The interactable will register himself on enable (in unity XRI code).

Side note: why is VoiceRequiresFocus private set? I needed to set it from code but I couldn't.

[AMollis]

Hi @anonymous2585 ,

Thank you for reporting this issue or requesting this feature. We appreciate your feedback and interest in MRTK3.

We have reviewed your issue or feature request and confirmed that it is valid. We have added it to our backlog and will prioritize it accordingly.

However, if you would like to speed up the process and contribute to the MRTK3 project, you are welcome to submit a Pull Request with your proposed fix or implementation. We would be happy to review your code and merge it into the main branch if it meets our quality standards.

Please let us know if you have any questions or need any assistance. Thank you for your support and collaboration.

Best regards,
The MRTK3 team