Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testplatform message #691

Merged
merged 5 commits into from
Apr 7, 2017
Merged

Conversation

@Faizan2304 Faizan2304 requested review from codito and smadala April 5, 2017 16:28
@msftclas
Copy link

msftclas commented Apr 5, 2017

@Faizan2304,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@smadala
Copy link
Contributor

smadala commented Apr 6, 2017

From #532 (comment)

  1. It would be great to not mandate the specification of the Framework. The test platform could smartly figure this information out.

We should fix this too.

Copy link
Contributor

@smadala smadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close #532 only when both parts addressed.

<body>
<trans-unit id="NoTestHostFileExist">
<source>No test is available in {0}. Make sure test project has a nuget reference of package "Microsoft.NET.Test.Sdk" and framework version settings are appropriate and try again.</source>
<target state="new">Could not find testhost.dll for source '{0}'. Make sure test project has a nuget reference of package "Microsoft.NET.Test.Sdkt". And also check the framework passed when running test.</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft.NET.Test.Sdkt is this expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it shouldn't. It has new tag associated with it. The source is correct. Actually in the beginning I had wrong string which I fixed in next commit. It updated the source tag in xlf file but the target tag remained the same. There is no issue with it as it will get updated by translated string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants