Create config file for test project targeting .NET Framework #642
Conversation
1) microsoft#613 2) microsoft#428 3) microsoft#391 4) microsoft#595 Fix: Generate config file for test project targeting .NET Framework. This config file has have binding redirect which is needed at time of running tests.
|
@Faizan2304, |
| Generate config file for test project targeting .NET Framework. This config file has have binding redirect which | ||
| is needed at time of running tests. | ||
| --> | ||
| <PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'"> |
There was a problem hiding this comment.
Does this ensure it is created only for net46 and other Desktop targets?
| --> | ||
| <PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'"> | ||
| <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects> | ||
| <GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType> |
There was a problem hiding this comment.
This doesn't seem to be documented in msdn: https://msdn.microsoft.com/en-us/library/2fc472t2(v=vs.110).aspx
Why is it required?
There was a problem hiding this comment.
There was a problem hiding this comment.
This is required due to this piece of code
https://github.com/Microsoft/msbuild/blob/dd5e8bc3f86ac98bd77d8971b00a6ad14f122f1a/src/XMakeTasks/Microsoft.Common.CurrentVersion.targets#L2027
|
@dotnet-bot test Windows / Release Build please |
| @@ -41,6 +41,15 @@ | |||
| <PropertyGroup> | |||
| <DebugType Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">Full</DebugType> | |||
| </PropertyGroup> | |||
|
|
|||
| <!-- | |||
| Generate config file for test project targeting .NET Framework. This config file has have binding redirect which | |||
There was a problem hiding this comment.
nit: "This config file has binding redirects needed to run tests."
| --> | ||
| <PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'"> | ||
| <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects> | ||
| <GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType> |
There was a problem hiding this comment.
|
@dotnet-bot test Windows / Release Build please |
Issue:
testhost#428Fix:
Generate config file for test project targeting .NET Framework. This config file has have binding redirect which is needed at time of running tests.