From 97c8ba5a2507b81b60a41f51c84cab3ee9d1f0ae Mon Sep 17 00:00:00 2001 From: Giulio Frasca Date: Wed, 20 Nov 2024 02:46:24 -0500 Subject: [PATCH] Correct empty values for repo branch and pr num passed to sdg_op Signed-off-by: Giulio Frasca --- pipeline.py | 2 +- standalone/standalone.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pipeline.py b/pipeline.py index 8285d654..cd9fa1e8 100644 --- a/pipeline.py +++ b/pipeline.py @@ -554,7 +554,7 @@ def gen_standalone(): # The list of executor names to extract details from to generate the standalone script executors = { "exec-data-processing-op": 'data_processing_op(max_seq_len={MAX_SEQ_LEN}, max_batch_len={MAX_BATCH_LEN}, sdg_path="{DATA_PVC_SDG_PATH}", model_path="{DATA_PVC_MODEL_PATH}", skills_path="{PREPROCESSED_DATA_SKILLS_PATH}", knowledge_path="{PREPROCESSED_DATA_KNOWLEDGE_PATH}")', - "exec-sdg-op": 'sdg_op(num_instructions_to_generate={num_instructions_to_generate}, pipeline="{sdg_pipeline}", repo_branch="{exec_git_clone_op_repo_branch}", repo_pr={exec_git_clone_op_repo_pr}, taxonomy_path="{TAXONOMY_DATA_PATH}", sdg_path="{DATA_PVC_SDG_PATH}")', + "exec-sdg-op": 'sdg_op(num_instructions_to_generate={num_instructions_to_generate}, pipeline="{sdg_pipeline}", repo_branch="{exec_git_clone_op_repo_branch or ""}", repo_pr={exec_git_clone_op_repo_pr or 0}, taxonomy_path="{TAXONOMY_DATA_PATH}", sdg_path="{DATA_PVC_SDG_PATH}")', "exec-git-clone-op": {}, "exec-huggingface-importer-op": 'huggingface_importer_op(repo_name="{REPO_GRANITE_7B_IMAGE}", model_path="{DATA_PVC_MODEL_PATH}")', "exec-run-mt-bench-op": 'run_mt_bench_op(best_score_file="{MT_BENCH_SCORES_PATH}",output_path="{MT_BENCH_OUTPUT_PATH}",models_folder="{CANDIDATE_MODEL_PATH_PREFIX}",models_path_prefix="{CANDIDATE_MODEL_PATH_PREFIX}", max_workers="{MAX_WORKERS}", merge_system_user_message={MERGE_SYSTEM_USER_MESSAGE})', diff --git a/standalone/standalone.py b/standalone/standalone.py index 6188689e..bedfb623 100755 --- a/standalone/standalone.py +++ b/standalone/standalone.py @@ -1160,7 +1160,7 @@ def set_precomputed_skills_data_ratio(sampling_size): ) """ exec_sdg_op_args = f""" -sdg_op(num_instructions_to_generate={num_instructions_to_generate}, pipeline="{sdg_pipeline}", repo_branch="{exec_git_clone_op_repo_branch}", repo_pr={exec_git_clone_op_repo_pr}, taxonomy_path="{TAXONOMY_DATA_PATH}", sdg_path="{DATA_PVC_SDG_PATH}") +sdg_op(num_instructions_to_generate={num_instructions_to_generate}, pipeline="{sdg_pipeline}", repo_branch="{exec_git_clone_op_repo_branch or ''}", repo_pr={exec_git_clone_op_repo_pr or 0}, taxonomy_path="{TAXONOMY_DATA_PATH}", sdg_path="{DATA_PVC_SDG_PATH}") """ return kubernetes.client.V1Container(