Dropdown: Changes RightAligned to EndAligned #5893
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All these components, options, and states are different types of objects, so I would not like to introduce one common interface for all of them. And if we would to add interface for each specific type then we would be back to the same problem, but with more complexity. Keep it simple. Just add the same comment to all places where it is needed.
Makes sense. I will open a new ticket for BarDropdown. |
stsrki
changed the title
stsrki
reviewed
Dec 13, 2024
| @@ -428,12 +428,12 @@ public bool Visible | |||
| /// If true, a dropdown menu will be right aligned. | |||
There was a problem hiding this comment.
Just update comments to mention the end, instead of right side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3835
Questions/todos:
The comments need to be updated as well. Regarding that: Should we consider unifying the source of
EndAlignedunder one interface and then using///<inheritdoc/>? This approach would help avoid repeating the same XML comment across four places:Dropdown.razor.cs,DropdownList.razor.cs,DropdownJSOptions, andDropdownState. It’s not just about the comments;EndAlignedhas the same meaning in all these contexts, so centralizing it makes sense.release notes need a record, but I will do it on the end.
There’s still one instance of
RightAlignedleft - inBarDropdown. However, this case is genuinely "right-aligned" because, even withdir="rtl", it retains its alignment. In contrast,Dropdownproperly respects the start-end directionality. Perhaps it’s worth reconsidering the functionality ofBarDropdownto align it with the start-end behavior (in a different task)?