Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIG-171 - Fixed ECBuilderMap and script #468

Merged
merged 3 commits into from
Jun 6, 2023
Merged

MIG-171 - Fixed ECBuilderMap and script #468

merged 3 commits into from
Jun 6, 2023

Conversation

imaimai86
Copy link
Contributor

@imaimai86 imaimai86 commented May 26, 2023

Fixed ECBuilderMap and script to update only ids in ec_builder_data and export only draft templates in the target org

Changes in export:

  • Fixed the Ec builder data map to contain only ids and ec_keys
  • Export Builder data maps for affected templates only(those being exported)
  • Export Builder data maps for published templates as well, if they are being exported

Changes in import:

  • Update only the ids of the ec__builder_data in target org
  • Update template in the target org only if they are in draft status

Common:

  • Fixed tests

Copy link
Collaborator

@joejean joejean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question @imaimai86, do you think the existing tests you have modified are cover all of the scenarios of the changes or do we need to add some more tests?

@imaimai86
Copy link
Contributor Author

imaimai86 commented Jun 6, 2023

Quick question @imaimai86, do you think the existing tests you have modified are cover all of the scenarios of the changes or do we need to add some more tests?

@joejean The tests in the repo covers export part of the process, and the modified tests covers the changes we made to the export

Copy link
Collaborator

@joejean joejean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants