Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitHub reporting of ABI-check #48

Open
gilles-peskine-arm opened this issue Jun 13, 2022 · 0 comments
Open

Improve GitHub reporting of ABI-check #48

gilles-peskine-arm opened this issue Jun 13, 2022 · 0 comments
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Jun 13, 2022

We sometimes merge pull requests when the ABI-check job fails, because it has common false positives that need to be manually reviewed.

We should change the reporting of ABI-check on GitHub so that:

  • If abi_check.py returns 1, the pr-merge job is recorded as a success.
  • There is a separate status for ABI-check on GitHub, which is recorded as a failure if abi_check.py returns nonzero or cannot run.

Also, abi_check now does more than just an ABI check: it also checks the API, some systematically generated tests, and some storage tests. So we should give it a clearer name in the new reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
None yet
Development

No branches or pull requests

1 participant