Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Rename Singular Attributes #419

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] Rename Singular Attributes #419

wants to merge 5 commits into from

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Dec 19, 2023 •
edited
Loading

Fixes #391

Implement two attribute name changes for 2 schema.TypeList that are singular that should be plural. Including StateUpgraders to and make this as easy as possible for existing resources.

Resource Old Attribute New Attribute
source kafka start_offset start_offsets
source postgres schema schemas

@dehume dehume changed the title [WIP] Rename singular attributes [WIP] Rename Singular Attributes Dec 19, 2023
dehume
dehume commented Dec 20, 2023
View reviewed changes
pkg/provider/acceptance_source_kafka_migration_test.go
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
)

func TestAccSourceKafkaMigration_basic(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still working on this. Still working on finding better examples of doing the migration tests.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dehume
❌ Dennis Hume

Dennis Hume seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev Awaiting requested review from bobbyiliev bobbyiliev will be requested when the pull request is marked ready for review bobbyiliev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres source: consider renaming schema and table options
2 participants
@dehume @CLAassistant