Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarantula Pro with MKS SGEN-L #936

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented May 26, 2023

Description

The Tarantula Pro originally shipped with an MKS GEN-L (8-bit) and was later shipped with an SGEN-L (32-bit), so I've added that option.

This PR also:

  • Generalizes extruder auto fan to use FAN1_PIN which will work correctly for both the GEN-L and SGEN-L builds
  • Enables Mesh Bed Leveling since there's plenty of room to spare & these beds are not flat 😄

Benefits

Improved config for both new & old Tarantula Pro builds.

Related Issues

None. Came up on Discord.

@MarlinFirmware MarlinFirmware deleted a comment from thisiskeithb Jun 1, 2023
@thinkyhead
Copy link
Member

I went ahead and split the config in two since the 32-bit board is likely to be able to support more features, so over time it can get more enhancements added.

@thinkyhead thinkyhead force-pushed the pr/tarantula_pro_with_sgen_l branch from 04248cb to ca81e78 Compare June 1, 2023 20:15
@thisiskeithb
Copy link
Member Author

thisiskeithb commented Jun 1, 2023

I went ahead and split the config in two since the 32-bit board is likely to be able to support more features, so over time it can get more enhancements added.

Just so I'm clear, is this only for machines with both 8-bit & 32-bit options?

I've combined multi-board configs into single configs for the Biqu B1 & (separately) BX, so those should stay combined as they are 32-bit builds?

@thinkyhead thinkyhead force-pushed the pr/tarantula_pro_with_sgen_l branch from ca81e78 to 58fe48a Compare June 1, 2023 20:16
@thinkyhead
Copy link
Member

thinkyhead commented Jun 1, 2023

Just so I'm clear, is this only for machines with both 8-bit & 32-bit options?

Any case where the MOTHERBOARD differs enough that it can support (some… many) more added features.

There's a general question as to how important the new tools I'm building for user configuration may become in the future, and whether we end up putting all the configurations into a database so we can auto-generate them, and whether the tools I'm building can be adaptable to configurations that have added options and conditions, and so on….

There is a growing tension between keeping the number of configuration files to a minimum versus these other considerations, especially as the number of configurations approaches 400 and beyond.

@thinkyhead thinkyhead merged commit 516effa into MarlinFirmware:import-2.1.x Jun 1, 2023
@thisiskeithb thisiskeithb deleted the pr/tarantula_pro_with_sgen_l branch June 1, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants