Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Ender-3 with SKR Mini E3 V3 Config #924

Merged
merged 4 commits into from
May 15, 2023
Merged

Improve Ender-3 with SKR Mini E3 V3 Config #924

merged 4 commits into from
May 15, 2023

Conversation

thisiskeithb
Copy link
Member

Description

Improve Ender-3 with SKR Mini E3 V3 Config

Benefits

Bring config more in line with other SKR Mini E3 configs

@cbagwell
Copy link

I aligned my config file with these changes and tested them and all went fine. A few notes.

  • These changes apply to Ender 3 Pro config in case you want to update that set as well (what I tested).
  • I left endstop interrupt enabled because its worked well for me so far.
  • I didn't test BLTOUCH changes since mine is connected to 5-pin connector. Perhaps that reduced my risk of misconfiguring BLTOUCH and leading to endstop issue as mentioned in that other issue.
  • I didn't test the PID values.

@thinkyhead thinkyhead force-pushed the import-2.1.x branch 2 times, most recently from 761890b to 2c8695b Compare May 2, 2023 02:08
Bring config more in line with other SKR Mini E3 configs
@thinkyhead
Copy link
Member

These changes apply to Ender 3 Pro config

@cbagwell — Every change without exception? What is the primary difference with the Ender-3 Pro over the Ender-3?

@EvilGremlin
Copy link
Contributor

Better PSU

@thisiskeithb
Copy link
Member Author

What is the primary difference with the Ender-3 Pro over the Ender-3?

As far as Marlin is concerned? Basically nothing.

Pro configs say “Ender-3 Pro” on the status screen “Ready” message and _Statusscreen.h.

@cbagwell
Copy link

cbagwell commented May 9, 2023

I'd almost forgotten about that import status screen. 😄 The Pro also comes with a magnetic bed instead of using clips but there are no features enabled that require knowledge of that (no probe for example). And I noticed even non-Pro is starting to ship with magnetic beds depending where you purchase and I wouldn't be surprised if they are totally the same as Pro's now since even the Pro no longer ships with a Meanwell PSU.

@thisiskeithb
Copy link
Member Author

I wouldn't be surprised if they are totally the same as Pro's now since even the Pro no longer ships with a Meanwell PSU.

The lines between Ender-3 SKUs are quite blurred at this point.

@thisiskeithb
Copy link
Member Author

We'd have a lot more Ender-3 Pro configs if we:

  • Back up the Ender-3 Pro's _Statusscreen.h
  • Nuke the contents of the Ender-3 Pro configs folder
  • Copy over Ender-3 configs & replace previously backed up _Statusscreen.h
  • Replace all mentions of "Ender-3" with "Ender-3 Pro"

...Then remember to always add an Ender-3 Pro config for each new Ender-3 config. Or automate it.

@thinkyhead
Copy link
Member

We'd have a lot more Ender-3 Pro configs…

Sounds like all that could be done with a README that explains the Ender-3 Pro is just the Ender-3 with some settings and files adjusted. But, if all Ender-3 configs were ported over to Ender-3 Pro configs it wouldn't be a major addition to the existing maintenance burden, as we're already doing "mostly automated" maintenance of over 300 configs now.

@thinkyhead thinkyhead merged commit 156526f into MarlinFirmware:import-2.1.x May 15, 2023
@thisiskeithb thisiskeithb deleted the pr/update_btt_skr_mini_e3_ender3 branch May 15, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants