-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ender-3 V2 / S1 DACAI LCD compatibility with custom UIs, improve LCD READMEs #880
fix: Ender-3 V2 / S1 DACAI LCD compatibility with custom UIs, improve LCD READMEs #880
Conversation
e0f2b1b
to
3d8d9e6
Compare
Some of the JPGs are increasing in size although they are not changing graphically. @ellensp recently compressed the images with JPEG.io so any images that are increasing in size should probably be run through that filter again. |
Currently there are two SYNWIT/VIEWE display versions. |
@mriscoc any chance you could update your page so the images are clickable to a larger image, not all of us have 20/20 vision... |
I think we should pull this page both into general marlin docs and into creality conf directory. |
I will try to do it, but users give me low-res images. |
I think @InsanityAutomation can make decent photos for all of them |
fba3a13
to
0bfbf05
Compare
Done. |
Description
This PR fixes the
private
asset bundle folder for DACAI LCDs, making them compatible with custom UIs.The following modifications have been made to the DACAI
private
folder:config.txt
has been adjusted to allow the font sizes to match the DWIN displaytruefont/font.ttf
has been changed from SimSun (serif) to SimHei (sans-serif)DWIN_SET
graphics asset bundle has been converted into DACAIZICO
formatAdditionally, the
README.md
files for Ender-3 S1 and Ender-3 V2LCD Files
folders have been updated as follows:LCD Files/README.md
:DWIN
andDACAI
LCDsLCD Files/README.md
has been updated to a general notice regarding the different types of display, redirecting to the comprehensive Ender-3 V2 display family readme mentioned aboveBenefits
The DACAI LCD files update ensures this display unit now works properly with all Creality UI-based custom interfaces, and with MarlinUI. Text and icons are now displayed properly.
Please note that MarlinUI in Landscape is still not possible on this display, as the DACAI unit appears to omit the API for display rotation.
The updated
README.md
files provide more information about the different types of displays, their compatibility with the different UIs, and ways to update them (where currently available).Related Issues
Partially fixes MarlinFirmware/Marlin#25195
Rendering issues are resolved, Landscape is incompatible due to display API limitations or currently unknown opcodes.