Fix SD card detection on BIGTREETECH SKR E3-DIP V1.x #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also the original config from BIGTREETECH's repository: https://github.com/bigtreetech/BIGTREETECH-SKR-E3-DIP-V1.0/blob/c93d0309a42848e0fa27f005e9b2031736be7e61/Firmware/Marlin-2.0.7.2-SKR-E3-DIP/Marlin/Configuration_adv.h#L1171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tested the example config on my Ender 3 with BigTreeTech SKR E3-DIP V1.0 board and I needed to leave this line comment out. With
SD_DETECT_STATE HIGHenabled, the SD card does not work and the printer shows "SD Init Fail" when I remove the card and "Media Removed" when I insert it.As far as I can tell v1.1 of the board has no changes in this regard:
Source: https://github.com/bigtreetech/BIGTREETECH-SKR-E3-DIP-V1.0
This comment MarlinFirmware/Marlin#20952 (comment) seems to confirm that
SD_DETECT_STATE HIGHshould be disabled even on board v1.1.The change enabling
SD_DETECT_STATE HIGHwas done here and I think that it was a mistake: 5512b13#diff-42021d0476fa94f14d9afaa0290738c3b67857151884b5c715c827d135c02b45R1167See also the original config from BIGTREETECH's repository: https://github.com/bigtreetech/BIGTREETECH-SKR-E3-DIP-V1.0/blob/c93d0309a42848e0fa27f005e9b2031736be7e61/Firmware/Marlin-2.0.7.2-SKR-E3-DIP/Marlin/Configuration_adv.h#L1171
Benefits
Fixes SD card on BIGTREETECH SKR E3-DIP V1.x boards when using example Marlin config.