Recipes broken on 0.20.x

[palday]

• are you running newest version (version from docs) ?
• can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie)
• What platform + GPU are you on? Linux, n/a (CairoMakie).

While trying to figure out why some recipes no longer worked, I started re-reading the recipe docs and looking at Makie's own internal use of recipes and found that there is an example in the docs: rainclouds.

Note that the the title, axis and category labels don't appear in the figure. Those are all set in

Makie.jl/src/basic_recipes/raincloud.jl

Lines 138 to 172 in a1d85a1

	function plot!(
	ax::Makie.Axis, P::Type{<: RainClouds},
	allattrs::Attributes, category_labels, data_array)
	plot = plot!(ax.scene, P, allattrs, category_labels, data_array)
	if any(x -> x isa AbstractString, category_labels)
	ulabels = unique(category_labels)
	if !haskey(allattrs, :orientation) || allattrs.orientation[] === :vertical
	ax.xticks = (1:length(ulabels), ulabels)
	else
	ax.yticks = (1:length(ulabels), ulabels)
	end
	end
	if haskey(allattrs, :title)
	ax.title = allattrs.title[]
	end
	if haskey(allattrs, :xlabel)
	ax.xlabel = allattrs.xlabel[]
	end
	if haskey(allattrs, :ylabel)
	ax.ylabel = allattrs.ylabel[]
	end
	reset_limits!(ax)
	return plot
	end
	function group_labels(category_labels, data_array)
	grouped = Dict{eltype(category_labels), Vector{Int}}()
	for (label, data_ix) in zip(category_labels, axes(data_array,1))
	push!(get!(grouped, label, eltype(data_array)[]), data_ix)
	end
	return pairs(grouped)
	end

In my own broken recipe, I inserted some code to see which methods were being called and discovered the analogous

plot!(ax::Makie.Axis, P::Type{<: MyPlotType}, allattrs::Attributes, args...) 

method was no longer being called despite being called on 0.19.x.

[jkrumbiegel]

raincloud is the odd one out of Makie's default recipes because of the nonstandard axis attributes etc. I'm actually not sure why it was allowed to be so different at the time. It kind of works around the missing complex recipe functionality of Makie