Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion between reset! and setstate! #3

Closed
klowrey opened this issue Dec 17, 2019 · 1 comment
Closed

Confusion between reset! and setstate! #3

klowrey opened this issue Dec 17, 2019 · 1 comment

Comments

@klowrey
Copy link
Contributor

klowrey commented Dec 17, 2019

lyceummujoco exposes setstate!(env, s) while lyceum base has a reset!(env, s) function. Their functionality seems to be generally the same: put the sim in a particular state s.

notably, LyceumAI's mppi function uses reset!(env, s) to reset the environment to a particular state; if length(s) != length(env.sim.initstate) there are problems. In this case setstate and reset functionally are the same.

If they are always the same, we should get rid of one of them.

@colinxs
Copy link
Contributor

colinxs commented Jan 9, 2020

fixed in Lyceum/LyceumBase.jl#7

@colinxs colinxs closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants