Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injection is currently broken due to upstream bug/discord changes #6

Open
LunNova opened this issue Sep 27, 2022 · 17 comments
Open

Injection is currently broken due to upstream bug/discord changes #6

LunNova opened this issue Sep 27, 2022 · 17 comments

Comments

@LunNova
Copy link
Owner

LunNova commented Sep 27, 2022

Upstream issue due to discord changes. See replugged-org/replugged#202 - says canary but applies to all builds now.

@LunNova LunNova pinned this issue Sep 28, 2022
@LunNova
Copy link
Owner Author

LunNova commented Sep 28, 2022

Bad news: replugged-org/replugged#205

@rhysperry111
Copy link

rhysperry111 commented Sep 28, 2022

The guys over at BetterDiscord suffered the same problem. I think they either partially or completely fixed it with this pull

EDIT: Didn't realise I'd managed to navigate out of the replugged repo, sorry for the spam

@LunNova
Copy link
Owner Author

LunNova commented Oct 1, 2022

Added withOpenAsar option which allows using https://openasar.dev for theming, but it doesn't work with the declarative config yet.

Looks like replugged are going for a rewrite in the rewrite branch so I expect it will take them some time.

@LunNova
Copy link
Owner Author

LunNova commented Oct 19, 2022

replugged-org/replugged@aad5018

"plugin support is here"

Looks like the rewrite is almost ready, plugins will need updated to work with it. I'll try to get it packaged at the weekend if it's in a workable state.

@LunNova
Copy link
Owner Author

LunNova commented Oct 23, 2022

Still rapidly iterating on things in that branch and doesn't seem ready for use yet. Maybe next weekend.

@LunNova
Copy link
Owner Author

LunNova commented Dec 13, 2022

The new replugged branch appears to be somewhat usable now. I hope to get this working at the weekend.

@somasis
Copy link
Contributor

somasis commented Jan 14, 2023

It looks like Replugged is becoming quite a lot more usable again- I'm not sure if the patches or installation process needs updating, but, they've at least got some beta versions out now.

@pupbrained
Copy link

Replugged was completely rewritten so, yes, the installation process does need updating. I have a simple flake for it that I use on my system, that I just modified from the one I used for Vencord. The two modifications seem to use very similar installations.

@somasis
Copy link
Contributor

somasis commented Mar 4, 2023

The rewrite has been finished.

https://github.com/replugged-org/replugged/releases/tag/v4.0.0

@babeuh
Copy link

babeuh commented Apr 3, 2023

The new replugged branch appears to be somewhat usable now. I hope to get this working at the weekend.

Any updates on this? @LunNova

@LunNova
Copy link
Owner Author

LunNova commented Jul 7, 2023

Sorry, no.

I've recently taken to using armcord from nixpkgs and not doing much custom, due to a lack of time to work on this.

It's about time to admit I don't have the bandwidth for this so if anyone else does get this working I'll put up a redirect notice / etc to their flake.

@Henry-Hiles
Copy link

Upstream issue due to discord changes. See replugged-org/replugged#202 - says canary but applies to all builds now.

This is now fixed upstream, so should be fine?

@LunNova
Copy link
Owner Author

LunNova commented Sep 9, 2023

The mkYarnPackage build for replugged stopped working at some point during their rewrite so someone will have to figure out how to fix that to update this.

error: builder for '/nix/store/q2s41wknk07xgiffvwhmb8z4glq47kxs-replugged-modules-4.0.0-beta0.25.drv' failed with exit code 1;
       last 10 log lines:
       > yarn config v1.22.19
       > success Set "yarn-offline-mirror" to "/nix/store/kshwvvc8l0v6nq95dhddcpd9wimb5w7h-offline".
       > Done in 0.01s.
       > yarn install v1.22.19
       > [1/4] Resolving packages...
       > [2/4] Fetching packages...
       > [] 0/898[] 13/898[] 24/898error An unexpected error occurred: "EACCES: permission denied, unlink '/nix/store/kshwvvc8l0v6nq95dhddcpd9wimb5w7h-offline/eslint-config-dmitmel.git'".
       > info If you think this is a bug, please open a bug report with the information provided in "/build/yarn-error.log".

@LunNova
Copy link
Owner Author

LunNova commented Sep 9, 2023

Similar to NixOS/nixpkgs#174114

@Henry-Hiles
Copy link

Why can't you just use npm run build? Or pnpm?

@LunNova
Copy link
Owner Author

LunNova commented Sep 9, 2023

You can't access online resources in nix builds. I didn't see they changed again from yarn to pnpm.

Looks like nobody's written tooling for pnpm for nix yet: NixOS/nixpkgs#231513

@LunNova
Copy link
Owner Author

LunNova commented Mar 9, 2024

NixOS/nixpkgs#290715 is trying to upstream pnpm support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants