Remove deprecated grpc.DialContext and replace it with grpc.NewClient

[majst01]

This also is not blocking anymore because it was detected broken since a while.

Subsequent calls to the grpc endpoint will error out if during grpc.NewClient the connection was not created successfully.

Summary by CodeRabbit

• New Features

  • Enhanced connection handling with updated security practices for establishing client connections.

• Bug Fixes

  • Improved handling of connection parameters, potentially leading to better error management and performance.

• Refactor

  • Simplified function signatures by removing unnecessary parameters, streamlining the dialing process.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve updates to the go.mod file, where several Google-related package versions have been incremented. Additionally, modifications were made to the lbdialer function in pkg/driver/driver.go and the Dial function in pkg/lb/lbgrpc/client.go, including the removal of the ctx parameter and adjustments to connection handling logic.

Changes

File Path	Change Summary
go.mod	Updated versions for several Google-related packages: genproto/api, genproto/rpc, grpc, and protobuf.
pkg/driver/driver.go	Modified lbdialer function to remove the ctx parameter in the call to lbgrpc.Dial.
pkg/lb/lbgrpc/client.go	Altered Dial function by removing the ctx parameter, updating connection options, and changing from grpc.DialContext to grpc.NewClient.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[majst01]

@rahman-lb is this PR also considered for merging ?

[rahman-lb]

@majst01 Please resolve the conflict , i'll review , test and merge.

[majst01]

@majst01 Please resolve the conflict , i'll review , test and merge.

Done

[rahman-lb]

plz resolve this conflict

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[majst01]

plz resolve this conflict

Should be resolved.

[rahman-lb]

thanks, i'll run test and merge it.

[rahman-lb]

@majst01 Can you check this conflict

[majst01]

I cant see any conflicts, also pulled master in and got no differences ? Weird