Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

npmignore windows build files #88

Closed
vweevers opened this issue Dec 10, 2018 · 0 comments
Closed

npmignore windows build files #88

vweevers opened this issue Dec 10, 2018 · 0 comments
Labels
cleanup Housekeeping semver-patch Bug fixes that are backward compatible

Comments

@vweevers
Copy link
Member

Thanks to irish-pub, I noticed some extra files that would be included in the npm package (deps/snappy/snappy.sln and a few others).

I think we have to make our .npmignore match .gitignore. Also, there's a couple of RocksDB directories we can exclude, e.g. https://github.com/Level/rocksdb/tree/master/deps/leveldb/leveldb-rocksdb/arcanist_util
@vweevers vweevers added cleanup Housekeeping maintenance General maintenance labels Jan 1, 2019
@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Mar 31, 2019
@vweevers vweevers mentioned this issue Apr 7, 2019
Merged
@vweevers vweevers removed the maintenance General maintenance label Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cleanup Housekeeping semver-patch Bug fixes that are backward compatible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vweevers