This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
use napi_create_int64 for approximate size #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a port of this change from Level/leveldown.
Currently the binding for
approximateSizestores the result asuint32. This supports only databases of up to 4GB and returns wrong results for larger DBs.The PR changes the code to use the full
uint64that is returned from RocksDB and converts it to a Javascript number usingnapi_create_int64. The result is approximate for values that do not satisfyNumber.isSafeInteger(). This should be fine because the original value returned by RocksDB is "approximate" in first place.