Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Update prebuildify and node-gyp-build #625

Merged
merged 7 commits into from
Apr 28, 2019
Merged

Update prebuildify and node-gyp-build #625

merged 7 commits into from
Apr 28, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Apr 27, 2019

Tackles the final items of #575. Alpine and iOS are yet to do but we have a separate issues for those (#388 and #626). Supersedes #622.

Semver-minor because of the added armv tag.

Once prebuild/docker-images#5 lands and is built+pushed, I'll temporarily modify our .travis.yml here to enable the arm job without uploading prebuilds. IMO we don't have to smoke-test a release again.

@vweevers vweevers added the semver-minor New features that are backward compatible label Apr 27, 2019
@vweevers vweevers requested a review from ralphtheninja April 27, 2019 09:39
@vweevers
Copy link
Member Author

Also closes #388.

@vweevers

This comment has been minimized.

@vweevers
Copy link
Member Author

ARM ✔️ (took 5 min 58 sec)

$ file prebuilds/*/*
prebuilds/android-arm64/node.napi.armv8.node: ELF 64-bit LSB  shared object, ARM aarch64, version 1 (SYSV), dynamically linked, stripped
prebuilds/android-arm/node.napi.armv7.node:   ELF 32-bit LSB  shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, stripped
prebuilds/linux-arm64/node.napi.armv8.node:   ELF 64-bit LSB  shared object, ARM aarch64, version 1 (SYSV), dynamically linked, stripped
prebuilds/linux-arm/node.napi.armv7.node:     ELF 32-bit LSB  shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, stripped

Alpine ✔️ (took 1 min 35 sec)

$ file prebuilds/*/*
prebuilds/linux-x64/node.napi.musl.node: ELF 64-bit LSB  shared object, x86-64, version 1 (SYSV), dynamically linked, stripped

@vweevers vweevers merged commit a9ef6f4 into master Apr 28, 2019
@vweevers vweevers deleted the update-prebuilds branch April 28, 2019 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver-minor New features that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants