Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Remove node 6, use prebuildify fork for now, build on node 8 #562

Merged
merged 3 commits into from
Dec 16, 2018
Merged

Remove node 6, use prebuildify fork for now, build on node 8 #562

merged 3 commits into from
Dec 16, 2018

Conversation

ralphtheninja
Copy link
Member

ralphtheninja
ralphtheninja commented Dec 16, 2018
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ralphtheninja
Copy link
Member Author

I'll let appveyor finish up before merging.

@ralphtheninja
Copy link
Member Author

And also needs rebasing ;)

@ralphtheninja
Copy link
Member Author

Looks like we got some error on appveyor even though the build passed

screenshot from 2018-12-16 18-31-46

@ralphtheninja
Copy link
Member Author

ralphtheninja commented Dec 16, 2018 •
edited
Loading

Just checked old sodium-native setup on appveyor and it shows similar output:

screenshot from 2018-12-16 18-37-28

From https://ci.appveyor.com/project/mafintosh/sodium-native/builds/20896258/job/ql6fno6kfrwi3rs2

We don't get the yellow output though on leveldown.

@ralphtheninja ralphtheninja merged commit 0e88cde into master Dec 16, 2018
@ralphtheninja ralphtheninja deleted the prebuildify-tweaks branch December 16, 2018 17:50
@ralphtheninja
Copy link
Member Author

Merged too early, current got canceled on appveyor.

@rvagg rvagg mentioned this pull request Dec 18, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphtheninja @vweevers