Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Support checksum options #172

Closed
juliangruber opened this issue May 6, 2015 · 7 comments
Closed

Support checksum options #172

juliangruber opened this issue May 6, 2015 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed stale This issue or pull request is old

Comments

@juliangruber
Copy link
Member

  • ReadOptions::verify_checksums for read operations, which, by default, don't verify checksums.
  • Options::paranoid_checks when opening a db will do aggressive checksum verification

moved over from Level/levelup#12

@juliangruber juliangruber added enhancement New feature or request help wanted Extra attention is needed labels May 6, 2015
@ralphtheninja
Copy link
Member

@vweevers Anything that's still interesting to implement? I could tackle if that's the case.

@vweevers
Copy link
Member

I have no idea. Personally I've never even seen a corrupted db. But maybe I would have, if verify_checksums was enabled? 🤷‍♂

@ralphtheninja
Copy link
Member

ralphtheninja commented May 18, 2019

@peakji Something that floats your boat?

@peakji
Copy link
Member

peakji commented May 19, 2019

I have never seen a corrupted db. And in my use case, I guess I'll keep verify_checksums disabled for better read performance.

However, there are some blockchain and coin projects using leveldown, maybe checksums are useful there?

@peakji
Copy link
Member

peakji commented May 19, 2019

BTW, leveldb got some interesting updates recently, we could import after their next release.

@vweevers
Copy link
Member

Just discovered that in RocksDB both verify_checksums and paranoid_checks are true by default and in rocksdb we currently only override paranoid_checks to be false. Should we set both to false?

@vweevers vweevers added the stale This issue or pull request is old label Dec 8, 2021
@vweevers
Copy link
Member

vweevers commented Dec 8, 2021

Can reopen if there's interest.

@vweevers vweevers closed this as completed Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed stale This issue or pull request is old
Projects
None yet
Development

No branches or pull requests

4 participants