Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency-check to all repositories #36

Closed
29 tasks done
ralphtheninja opened this issue Jul 1, 2018 · 8 comments
Closed
29 tasks done

Add dependency-check to all repositories #36

ralphtheninja opened this issue Jul 1, 2018 · 8 comments
Assignees
Labels
maintenance General maintenance

Comments

@ralphtheninja
Copy link
Member

ralphtheninja commented Jul 1, 2018

  • abstract-leveldown
  • awesome
  • codec
  • community
  • concat-iterator
  • database
  • deferred-leveldown
  • electron-demo
  • encoding-down
  • errors
  • iterator-stream
  • lazy-open
  • level
  • level-browserify
  • leveldb.org
  • leveldown
  • leveldown-hyper
  • level-hyper
  • level-js
  • level-rocksdb
  • level-test
  • level-ttl
  • levelup
  • level-ws
  • mem
  • memdown
  • packager
  • rocksdb
  • subleveldown
@vweevers
Copy link
Member

vweevers commented Jul 1, 2018

Personal request: not before fixing Windows compat in dependency-check, please :)

@ralphtheninja
Copy link
Member Author

Lets fix dependency-check first then 😉

@vweevers
Copy link
Member

vweevers commented Jul 6, 2018

@ralphtheninja
Copy link
Member Author

@vweevers
Copy link
Member

Nice!

@vweevers vweevers added the maintenance General maintenance label Jan 1, 2019
@vweevers vweevers self-assigned this Jan 6, 2019
@vweevers
Copy link
Member

vweevers commented Jan 6, 2019

@ralphtheninja do you want to add npm run dependency-check to the test script, or prepublishOnly?

@ralphtheninja
Copy link
Member Author

@ralphtheninja do you want to add npm run dependency-check to the test script, or prepublishOnly?

I have no strong opinion. Do what feels best to you :)

@vweevers
Copy link
Member

vweevers commented Jan 6, 2019

I'm leaning towards prepublishOnly because dependencies don't change that often, so I'll go with that.

Also I think I prefer to skip --unused, there are too many devDependencies to --ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance
Projects
None yet
Development

No branches or pull requests

2 participants