Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Decide whether gte/gt/lte/lt should take precedence over start/end or ..? #70

Closed
rvagg opened this issue Aug 19, 2015 · 4 comments
Closed
Labels
discussion Discussion

Comments

@rvagg
Copy link
Member

rvagg commented Aug 19, 2015

See dominictarr/ltgt#1 for details

Basically there exists a discrepancy between memdown and leveldown where memdown will decide to prefer lte and lt, discarding end if it exists, while leveldown takes the minim of the options. Same would go for gte, gt and start (and the reverse combinations as well).

One of them should be wrong, we need to decide which and implement conformance tests for it here.

@mcollina
Copy link
Member

That's a fine detail. I would go for lt over end, and gt over start. I would also deprecate start and end.

@juliangruber
Copy link
Member

I'm as well for giving the more specific and easy to grasp options, gte/gt/lte/lt, precedence over start/end.

@dominictarr
Copy link
Contributor

my position is not use start/end if the relavant gt/lt/gte/lte/reverse option is defined.
(start may indicate the high value (lt) if it's reverse=true

@vweevers
Copy link
Member

Closing because of Level/community#86.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion Discussion
Projects
None yet
Development

No branches or pull requests

5 participants