Image api rework #5260
Draft
Image api rework #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
image-api-rework
branch
from
b38a9ee to
d252be2
Compare
Nutomic
force-pushed
the
image-api-rework
branch
from
09b06f0 to
60ba7af
Compare
Nutomic
force-pushed
the
image-api-rework
branch
from
f66e392 to
7c771d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/api/v4/image/crates/api_common/src/image.rs, no more exposing of pictrs data structurescrates/routes/imagesadapt_request()for image upload, not for simple things like delete or health checkPOST /api/v4/account/avatarwhich directly takes image upload, instead of setting avatar url via/api/v4/account/settings/saveHave a look at the current changes. If its good I will do the same for user banner, community icon/banner and site icon/banner.