Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cursor pagination to report_combined view #5244

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Add cursor pagination to report_combined view #5244

merged 4 commits into from
Dec 2, 2024

Conversation

dullbananas
Copy link
Collaborator

Modifies PR #5231

@dullbananas dullbananas marked this pull request as ready for review December 2, 2024 05:39
@dullbananas dullbananas mentioned this pull request Dec 2, 2024
Open
dessalines
dessalines approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! This is really helpful, and I'll be able to use it for the other tables also.

@dessalines dessalines merged commit 588e1f6 into combined_tables_2 Dec 2, 2024
1 of 2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the combined_tables_2_cursor_pagination branch December 3, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@phiresky phiresky Awaiting requested review from phiresky phiresky is a code owner

@Nutomic Nutomic Awaiting requested review from Nutomic Nutomic is a code owner

@SleeplessOne1917 SleeplessOne1917 Awaiting requested review from SleeplessOne1917 SleeplessOne1917 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dullbananas @dessalines