Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent instance types (T3, R5, etc.) are not supported #294

Closed
cristim opened this issue Sep 7, 2018 · 5 comments · Fixed by #308 or andrewl3wis/AutoSpotting#1 · May be fixed by #295
Closed

Recent instance types (T3, R5, etc.) are not supported #294

cristim opened this issue Sep 7, 2018 · 5 comments · Fixed by #308 or andrewl3wis/AutoSpotting#1 · May be fixed by #295

Comments

@cristim
Copy link
Member

cristim commented Sep 7, 2018

Github issue

  • Bug Report

Build number

up to build 929

Configuration

  • T3, R5, etc. instances as initial instance type set on the ASG
  • other on-demand instance types that would normally be replaceable by these recent instance types

Summary

AutoSpotting lacks support for the recent instance types, because we lack spec and/or pricing information for them, which should come from the upstream ec2instances.info instance type database.

Steps to reproduce

  • Use AutoSpotting against a group of T3 on-demand instance types with the allowed instances types configuration set to "current".
    and also
  • Use AutoSpotting against a group of C5 on-demand instance types with the allowed instances types configuration set to "t3*"

Expected results

For both these cases the groups should be replaced by T3 spot instances.

Actual results

The groups keep running their on-demand nodes, AutoSpotting fails to launch any spot nodes for them.
This was referenced Sep 7, 2018
Closed
Open
@bilalmughal
Copy link

@cristim Since this ec2instance.info issue has been resolved. Now it should fetch instance info properly.

@cristim
Copy link
Member Author

cristim commented Nov 29, 2018

@bilalmughal thanks for the heads-up, I'll create a new build containing the updated instance type information.

cristim added a commit that referenced this issue Nov 29, 2018
@cristim
Update dependencies, including instance type data
dfcd0c0 
Fixes #294.
@cristim cristim mentioned this issue Nov 29, 2018
Merged
12 tasks
cristim added a commit that referenced this issue Nov 29, 2018
@cristim
Update dependencies, including instance type data
69e5e39 
Fixes #294.
@cristim
Copy link
Member Author

cristim commented Nov 29, 2018

@bilalmughal please give #308 a try, this should add support for all recent instance types.

I think as of now we need to manually blacklist the ARM instance types, before we have a way to distinguish them by some attributes.

@bilalmughal
Copy link

@cristim I can not give it a try as of now. I am on stable build in production and can not do it now.

@cristim
Copy link
Member Author

cristim commented Nov 29, 2018

@bilalmughal feel free to take your time, but I'll only merge this once myself or someone else manages to test it and can confirm it works as expected.

cristim added a commit that referenced this issue Nov 29, 2018
@cristim
Update dependencies, including instance type data (#308)
7647f58 
* Update dependencies, including instance type data

Fixes #294.

* Rename repo to AutoSpotting/AutoSpotting

* Add a new coveralls token
@andrewl3wis andrewl3wis mentioned this issue Dec 7, 2018
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cristim @bilalmughal