-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation EntityShape #571
base: master
Are you sure you want to change the base?
Conversation
Github Actions fails because entityshape is not available for Python 3.7. The problem will be solved next week with the depreciation of 3.7 in WBI. |
43f0bef
to
5e76716
Compare
@dpriskorn What's your opinion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work :)
See my inline comments for suggestions.
Also, please note than the support for shex is very basic in entityshape right now. See dpriskorn/entityshape#7 |
Note: new version with breaking change https://github.com/dpriskorn/entityshape/releases/tag/0.1.0 |
LGTM |
c6e23b5
to
aa81f3b
Compare
aa81f3b
to
9b22100
Compare
@dpriskorn |
Fix #470