Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.0: write_required returns True when no write is required #380

Open
dpriskorn opened this issue Jul 19, 2022 · 3 comments
Open

v0.12.0: write_required returns True when no write is required #380

dpriskorn opened this issue Jul 19, 2022 · 3 comments

Comments

@dpriskorn
Copy link
Contributor

bild
code is here https://github.com/internetarchive/wcdimportbot/blob/00dc45896d7e85e96f934bd13be2e9c6931cda17/src/models/wikibase/crud/update.py#L117

@dpriskorn
Copy link
Contributor Author

I could try to provide a few lines reproducing the issue. Or a new test that fails.

@LeMyst
Copy link
Owner

LeMyst commented Aug 25, 2022

I'll check this next weekend.

@dpriskorn
Copy link
Contributor Author

dpriskorn commented Nov 22, 2022

James seems to have found a nice solution by simply comparing the json before/after😀
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants