Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"double free or corruption" when trying to zoom in Song Editor, when there's a large sample loaded #7576

Open
1 task done
0xf0xx0 opened this issue Nov 14, 2024 · 1 comment · May be fixed by #7577 or #7599
Open
1 task done

"double free or corruption" when trying to zoom in Song Editor, when there's a large sample loaded #7576

0xf0xx0 opened this issue Nov 14, 2024 · 1 comment · May be fixed by #7577 or #7599
Labels
bug

Comments

@0xf0xx0
Copy link
Contributor

0xf0xx0 commented Nov 14, 2024

System Information

EndeavourOS (Arch Linux)

LMMS Version(s)

1.3.0-alpha.1.720+gada836c98

Most Recent Working Version

e0ae8a1 (it's not happy, but it doesn't crash)

Bug Summary

When trying to zoom in the song editor, LMMS freezes and crashes with a "double free or corruption (!prev)". A project file + sample to reproduce is attached.

doin a bisect revealed 0363ee6 as the offending commit.

Expected Behaviour

LMMS shouldn't freeze and crash.

Steps To Reproduce

  1. Load a long sample (the one im usin is 7m)
  2. try to use the slider to zoom
  3. behold, your wallpaper

Logs

double free or corruption (!prev)
[1]    111944 IOT instruction (core dumped)  lmms

Screenshots / Minimum Reproducible Project

longcrash.zip

Please search the issue tracker for existing bug reports before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.
@0xf0xx0 0xf0xx0 added the bug label Nov 14, 2024
@khoidauminh
Copy link
Contributor

I have no idea why this happens but changing this line seems to have made the bug disappear

-       const size_t maxFrames = static_cast<size_t>(numPixels * framesPerPixel);
+       const size_t maxFrames = numPixels * static_cast<size_t>(framesPerPixel);

@khoidauminh khoidauminh linked a pull request Nov 15, 2024 that will close this issue
Open
@sakertooth sakertooth linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@0xf0xx0 @khoidauminh