Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/expanding domain #52

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Feature/expanding domain #52

merged 4 commits into from
Mar 9, 2021

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Feb 18, 2021

Class that takes a user defined python function and uses it to feed nodes into the simulation. Currently restricted to ellipsoids/spheres for the initial sub-region. Tested for RZ/2d/3d, fluid/solid, & multiple nodelists

@jmpearl jmpearl requested a review from jmikeowen February 24, 2021 00:48
@jmikeowen
Copy link
Collaborator

This looks pretty reasonable. My only request is that we move the class to the src/Boundary package, since this is really a boundary condition.

@jmpearl
Copy link
Collaborator Author

jmpearl commented Mar 1, 2021

sounds good, I'll shift it over

Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now.

@jmikeowen jmikeowen merged commit 4c6501a into develop Mar 9, 2021
@jmikeowen jmikeowen deleted the feature/ExpandingDomain branch March 9, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants