Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake find_package Python bugfix. #250

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

mdavis36
Copy link
Collaborator

@mdavis36 mdavis36 commented Dec 13, 2023

Summary

  • This PR is a bugfix
  • It does the following:
    • Defines Python*_EXECUTABLE to ensure CMake uses the explicit spack installation passed in config files and doesn't try to pick up system installs.
    • Moves the definition of the python install paths before BLT to be consistent across the project submodules.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

…ilt python explicitly; Defining before including BLT to ensure all submodules in our CMake system are using the exact same python install.
@mdavis36 mdavis36 added this to the 2024.01.0 Release milestone Dec 13, 2023
@mdavis36 mdavis36 requested review from jmikeowen and ldowen December 13, 2023 00:26
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

@mdavis36 mdavis36 merged commit 7f2cac9 into develop Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants