Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gym dependency #375

Closed
aowen87 opened this issue Apr 19, 2023 · 6 comments · Fixed by #378
Closed

Update gym dependency #375

aowen87 opened this issue Apr 19, 2023 · 6 comments · Fixed by #378
Assignees
@rusu24edward
Labels
bug Something isn't working
Milestone
Version 0.2.6

Comments

@aowen87
Copy link

aowen87 commented Apr 19, 2023

Would it be possible to update the gym version dependency? There are some conflicts between pip and older versions of gym that I'm seeing crop up in Github's CI.
@aowen87
Copy link
Author

aowen87 commented Apr 19, 2023

On second thought, this might be a bad idea. It seems like there are a lot of breaking changes in newer versions. I'll see if I can get Github to play nice.

@aowen87 aowen87 closed this as completed Apr 19, 2023
@aowen87
Copy link
Author

aowen87 commented Apr 19, 2023

For future reference, here is the issue I was looking at and a temporary solution: openai/gym#3176

@aowen87
Copy link
Author

aowen87 commented Apr 19, 2023

I'm re-opening this as I'm finding other dependencies are requiring a newer version of gym. It's not an immediate need, but it would be nice to have the upgrade at some point.

@aowen87 aowen87 reopened this Apr 19, 2023
@rusu24edward
Copy link
Collaborator

rusu24edward commented May 2, 2023 •
edited
Loading

See #266 for context. I will work to update now since the underlying issue with the gym version seems to have been resolved in rllib.

@rusu24edward rusu24edward self-assigned this May 2, 2023
@rusu24edward rusu24edward added the bug Something isn't working label May 2, 2023
@rusu24edward rusu24edward added this to the Next Release milestone May 2, 2023
@rusu24edward
Copy link
Collaborator

Temporary fix is to include setuptools<67.0 at the top of the requirements file

@rusu24edward rusu24edward mentioned this issue May 2, 2023
Closed
@rusu24edward
Copy link
Collaborator

Temporary fix is to include setuptools<67.0 at the top of the requirements file

This didn't work. Exploring down RLlib's rabbit hole, it looks like the best solution is to set numpy < 1.24.

@rusu24edward rusu24edward mentioned this issue May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rusu24edward rusu24edward

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.2.6
Development

Successfully merging a pull request may close this issue.

Using get inf from newer versions of gym LLNL/Abmarl
2 participants
@aowen87 @rusu24edward