[BUG]: Closed terminal leaving ghost tiles when multiple terminal windows open #1152
Labels
bug
Something isn't working
Comments
|
Issue has been reported by someone else in this discord thread, though with something other than windows terminal |
|
I'm not able to reproduce this with Windows Terminal 🤔 - I wonder if this is something specific to Windows 10 |
|
This might be related to this issue on Windows terminal microsoft/terminal#17298. How exactly are you closing the window? To me after closing the window it takes a second but then the ghost tile and border disappears. This is because the workaround for the issue above is having a thread going on every second checking for this kind of windows and remove them. That's why it takes a few milliseconds to a second but it always removes them. There is even a line on the logs saying: Can you check your logs to see if the line above ever shows after you close it? |
|
Didn't find anything related to reaper in the logs. Komorebi doesn't seem to create the log file for me so I used the log command and got these logs when closing the terminal window. This behavior was fixed for me a while back but again started happening randomly. Happens when using both the close button for the window as well as the whkd binding |
If I have only one terminal open and close it, this happens and the empty space is reclaimed after a second. But if I have two terminals open and close one, its empty space creates a lingering ghost tile. |
The logs are kept on It seems to me that the reaper thread has stopped for some reason. @LGUG2Z there should be a There should be some error in the logs saying what happened. The repear thread should restart itself even if there is an error, so it would be important to get those logs to understand exactly what might have happened. |
|
Ah, thanks. I was looking for logs in the komorebi folder inside localappdata. These are the logs when closing only one of the two terminals (no reaper reaped log but there is an error): These are the logs when opening 2 terminal windows, then closing both of them. Reaper does seem to trigger when I close both of the open terminals and then the space is reclaimed. Note: I have a floating nvim window open that I switch to at the end. |
|
Also found another strange behavior with windows terminal. Steps to recreate:
This leaves a transparent window with the same titlebar as the closed terminal, like so: This behavior seems kinda unpredictable as when I first encountered this, it didn't leave a transparent window but only a ghost tile that could be fixed by maximizing, then unmaximizing the non-terminal window. I started testing it and then the transparent window started appearing. Logs recorded after opening a terminal, maximizing, closing it. At the end, I minimize the transparent window and switch to a floating nvim window |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
I know the bug report template says not to open issues for ghost tiles but in this case, ignoring the window causing the ghost tile is not a proper fix. Happens to me with windows terminal where, if I open multiple terminal windows and close one, the empty space isn't occupied by any other window. Running
komorebic visible-windowsshows that komorebi still thinks the closed window is still there. Example screenshot and output:{ "AUO723C-5&10278117&0&UID256": [ { "title": "New Issue · LGUG2Z/komorebi — Mozilla Firefox", "exe": "firefox.exe", "class": "MozillaWindowClass" }, { "title": "PowerShell", "exe": "WindowsTerminal.exe", "class": "CASCADIA_HOSTING_WINDOW_CLASS" }, { "title": "PowerShell", "exe": "WindowsTerminal.exe", "class": "CASCADIA_HOSTING_WINDOW_CLASS" } ] }Moving everything off the workspace will then create a transparent window with the window title of the closed window (shown below) which can then be closed.
Not sure if this is being caused by Windows Terminal as closing the terminal seems to kill its powershell process as well when viewing inside Task Manager.
Version Information
OS Name: Microsoft Windows 10 Home
OS Version: 10.0.19045 N/A Build 19045
komorebic 0.1.30
tag:v0.1.30
commit_hash:9a3dbccc
build_time:2024-11-03 23:49:52 +00:00
build_env:rustc 1.82.0 (f6e511eec 2024-10-15),stable-x86_64-pc-windows-msvc
Komorebi Configuration
{ "$schema": "https://raw.githubusercontent.com/LGUG2Z/komorebi/v0.1.30/schema.json", "app_specific_configuration_path": "$Env:KOMOREBI_CONFIG_HOME/applications.json", "window_hiding_behaviour": "Cloak", "cross_monitor_move_behaviour": "Insert", "default_workspace_padding": 0, "default_container_padding": 0, "border_padding": 0, "border_offset": 0, "border_width": 2, "border": true, "border_colours": { "single": "#fff", "stack": "#00a542", "monocle": "#ff3399" }, "mouse_follows_focus": false, "monitors": [ { "workspaces": [ { "name": "1", "layout": "VerticalStack", "initial_workspace_rules": [ { "id": "emacs.exe", "kind": "Exe", "matching_strategy": "Equals" } ] }, { "name": "2", "layout": "VerticalStack", "initial_workspace_rules": [ { "id": "firefox.exe", "kind": "Exe", "matching_strategy": "Equals" } ] }, { "name": "3", "layout": "VerticalStack" }, { "name": "4", "layout": "VerticalStack" }, { "name": "5", "layout": "VerticalStack" } ] } ], "ignore_rules": [ { "kind": "Exe", "id": "Zebar.exe", "matching_strategy": "Equals" }, { "kind": "Title", "id": "[Pp]icture.in.[Pp]icture", "matching_strategy": "Regex" }, { "kind": "Title", "id": "Firefox — Sharing Indicator", "matching_strategy": "Equals" } ], "stackbar": { "height": 20, "mode": "OnStack", "tabs": { "width": 300, "focused_text": "#00a542", "unfocused_text": "#b3b3b3", "background": "#141414" } } }Hotkey Configuration
Output of komorebic check
KOMOREBI_CONFIG_HOME detected: C:\Users\sujal.config\komorebi
Looking for configuration files in C:\Users\sujal.config\komorebi
Found komorebi.json; this file can be passed to the start command with the --config flag
Found C:\Users\sujal.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag
The text was updated successfully, but these errors were encountered: