Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for resolving conflicts when using git-merge [INS-4638] #8185

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

yaoweiprc
Copy link
Contributor

@yaoweiprc yaoweiprc commented Nov 20, 2024

Show resolving conflicts modal when users merge another branch to current branch.
Users must commit uncommitted changes before merge.

  • Update prompt-button component, now its onClick property can be an async function, and the button will show loading status when the promise is unsettled.
  • Update merge method in git-vcs.ts, now it can catch MergeConflictErrors like what we did in git pull.
  • Update mergeGitBranchAction method in git-actions.tsx, now it can be called directly instead of working as a data loader action.
  • Update git-branches-modal.tsx
    • Add an errMsg line in each branch block to show error messages when operating branches. I think it's a better way than overlaying a warning popup on top of the current modal.
    • Add code to capture conflict errors and display a conflict resolution modal.
  • Remove unused fetcher in git-staging-modal.tsx

gatzjames
gatzjames previously approved these changes Nov 21, 2024
filfreire
filfreire previously approved these changes Nov 21, 2024
@yaoweiprc yaoweiprc dismissed stale reviews from filfreire and gatzjames via 3fd59dd November 21, 2024 09:48
@CurryYangxx CurryYangxx force-pushed the feat/resolve-conflict-git-merge branch from 3fd59dd to 0a1a366 Compare November 22, 2024 06:06
@gatzjames gatzjames force-pushed the feat/resolve-conflict-git-merge branch from d77da88 to 1aaedf3 Compare November 25, 2024 11:38
@filfreire filfreire merged commit bc8aa38 into develop Nov 25, 2024
8 checks passed
@filfreire filfreire deleted the feat/resolve-conflict-git-merge branch November 25, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants