Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escape warnings. #1907

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Fix escape warnings. #1907

merged 2 commits into from
Nov 30, 2018

Conversation

Natim
Copy link
Member

@Natim Natim commented Nov 30, 2018

Fixes #1906

  • Add a changelog entry.

@Natim Natim force-pushed the 1906-escape-warning branch from fd78d2b to 5244c4c Compare November 30, 2018 14:02
@Natim Natim requested a review from leplatrem November 30, 2018 14:13
@Natim
Copy link
Member Author

Natim commented Nov 30, 2018 •
edited
Loading

Can you check if it fixed it?

@leplatrem
Copy link
Contributor

Yes it did:
https://travis-ci.org/Kinto/kinto/jobs/461791830#L606

The tests output a loooot of warnings (https, postgresql config...)

leplatrem
leplatrem approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small changelog maybe?

@Natim
Copy link
Member Author

Natim commented Nov 30, 2018

For a one char commit? 😂

@Natim Natim force-pushed the 1906-escape-warning branch from e124ee3 to 1cf1d89 Compare November 30, 2018 16:20
@leplatrem leplatrem merged commit ea23d85 into master Nov 30, 2018
@leplatrem leplatrem deleted the 1906-escape-warning branch November 30, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leplatrem leplatrem leplatrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Natim @leplatrem