Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the delete-collection command #1959

Closed
leplatrem opened this issue Jan 4, 2019 · 3 comments
Closed

Remove the delete-collection command #1959

leplatrem opened this issue Jan 4, 2019 · 3 comments
Labels
easy-pick question

Comments

@leplatrem
Copy link
Contributor

This command was introduced to fix a very specific use-case a long time ago where we had created a collection with an invalid ID. It could thus not be deleted via the HTTP API.

I think we can remove it.

(from #1953)
@Natim
Copy link
Member

Natim commented Jan 4, 2019

Yes it makes sense.

@AnanthKumarVasamsetti
Copy link

Hi, can I take up this bug and work on. As I started my open source contribution this would be my first fix

@leplatrem
Copy link
Contributor Author

leplatrem commented Jan 6, 2019 •
edited
Loading

Welcome onboard! Go ahead ;)

In brief..

  • remove the code itself
  • remove the tests
  • remove the docs
  • add a CHANGELOG entry :)

@Bjdufre1 Bjdufre1 mentioned this issue Jan 9, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy-pick question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Natim @leplatrem @AnanthKumarVasamsetti