Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Overall review comments #118

Open
lakshmih opened this issue Nov 19, 2024 · 1 comment
Open

SDK: Overall review comments #118

lakshmih opened this issue Nov 19, 2024 · 1 comment

Comments

@lakshmih
Copy link

lakshmih commented Nov 19, 2024

We tried running the SDK as is and have some comments/ feedback on specific samples. Creating an issue so we can discuss this.

cllayerinfo - No Output from the sample

nbodycpp - Passes but animation does not close
conwaycpp - Passes but animation does not close

saxpy - Fails with:
Verification failed! -9127.552734 != -9127.553711 at index 1
Error: CL_INVALID_VALUE

saxpycpp - Fails with:
Error: Verification FAILED!

For the first two tests, we should perhaps improve the sample to provide meaningful output and to exit cleanly. In general, interested in checking if these samples behave the same on other implementations as well.

Rest of the samples look okay on initial review / run.

General comment that it would be useful for samples to log something to stdout if everything ran successfully,.

@bashbaug
Copy link
Contributor

bashbaug commented Dec 7, 2024

Discussed in the December 3rd teleconference:

  • For cllayerinfo, we filed cllayerinfo is not printing anything if no layers are found OpenCL-ICD-Loader#247 for tracking.
  • For saxpy and saxpycpp, Qualcomm will investigate why the sample is failing on their implementation. It's possible there is an error in the sample, but we haven't seen failures on other implementations.
  • The graphical applications are behaving as expected, and will not close automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants