Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PkgEval] TensorOperations may have a testing issue on Julia 0.4 (2014-10-08) #3

Closed
IainNZ opened this issue Oct 8, 2014 · 5 comments

Comments

@IainNZ
Copy link

IainNZ commented Oct 8, 2014

PackageEvaluator.jl is a script that runs nightly. It attempts to load all Julia packages and run their tests (if available) on both the stable version of Julia (0.3) and the nightly build of the unstable version (0.4). The results of this script are used to generate a package listing enhanced with testing results.

On Julia 0.4

  • On 2014-10-05 the testing status was Tests pass.
  • On 2014-10-08 the testing status changed to Tests fail, but package loads.

Tests pass. means that PackageEvaluator found the tests for your package, executed them, and they all passed.

Tests fail, but package loads. means that PackageEvaluator found the tests for your package, executed them, and they didn't pass. However, trying to load your package with using worked.

Special message from @IainNZ: This change may be due to breaking changes to Dict in JuliaLang/julia#8521, or the removal of deprecated syntax in JuliaLang/julia#8607.

This issue was filed because your testing status became worse. No additional issues will be filed if your package remains in this state, and no issue will be filed if it improves. If you'd like to opt-out of these status-change messages, reply to this message saying you'd like to and @IainNZ will add an exception. If you'd like to discuss PackageEvaluator.jl please file an issue at the repository. For example, your package may be untestable on the test machine due to a dependency - an exception can be added.

Test log:

>>> 'Pkg.add("TensorOperations")' log
INFO: Installing Cartesian v0.3.0
INFO: Installing TensorOperations v0.3.0
INFO: Package database updated
INFO: METADATA is out-of-date a you may not have the latest version of TensorOperations
INFO: Use `Pkg.update()` to get the latest versions of your packages

>>> 'using TensorOperations' log
Julia Version 0.4.0-dev+998
Commit e24fac0 (2014-10-07 22:02 UTC)
Platform Info:
  System: Linux (x86_64-unknown-linux-gnu)
  CPU: Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Sandybridge)
  LAPACK: libopenblas
  LIBM: libopenlibm
  LLVM: libLLVM-3.3

>>> test log
ERROR: `Dict{K,V}` has no method matching Dict{K,V}(::UnitRange{Int64}, ::UnitRange{Int64})
 in indexin at array.jl:1151
 in tensorcopy at /home/idunning/pkgtest/.julia/v0.4/TensorOperations/src/tensorcopy.jl:11
 in include at ./boot.jl:245
 in include_from_node1 at ./loading.jl:128
 in include at ./boot.jl:245
 in include_from_node1 at loading.jl:128
 in process_options at ./client.jl:293
 in _start at ./client.jl:362
 in _start_3B_3789 at /home/idunning/julia04/usr/bin/../lib/julia/sys.so
while loading /home/idunning/pkgtest/.julia/v0.4/TensorOperations/test/tests3.jl, in expression starting on line 7
while loading /home/idunning/pkgtest/.julia/v0.4/TensorOperations/test/runtests.jl, in expression starting on line 8

INFO: Testing TensorOperations
==========================[ ERROR: TensorOperations ]===========================

failed process: Process(`/home/idunning/julia04/usr/bin/julia /home/idunning/pkgtest/.julia/v0.4/TensorOperations/test/runtests.jl`, ProcessExited(1)) [1]

================================================================================
INFO: No packages to install, update or remove
ERROR: TensorOperations had test errors
 in error at error.jl:21
 in test at pkg/entry.jl:719
 in anonymous at pkg/dir.jl:28
 in cd at ./file.jl:20
 in cd at pkg/dir.jl:28
 in test at pkg.jl:68
 in process_options at ./client.jl:221
 in _start at ./client.jl:362
 in _start_3B_3789 at /home/idunning/julia04/usr/bin/../lib/julia/sys.so


>>> end of log
@garrison
Copy link
Contributor

TensorOperations.jl is indeed broken on Julia 0.4, as Cartesian.jl itself fails to load. Would it be appropriate at this point to migrate to Base.Cartesian and remove the ability to run on julia 0.2? If so, we'd still need to remove the @ngenerate calls to get things working on julia 0.4. I'm guessing supporting julia 0.4 exclusively would even lead to some improvements due to generated functions, but you (@Jutho) are more of an expert on them than me.

@Jutho
Copy link
Owner

Jutho commented May 17, 2015

I have the updated version (which will indeed be 0.4 exclusive and use all the @generated goodies) mostly ready. This has a very dramatic impact (in the good sense) on the load time of TensorOperations. I am also trying to improve the index notation part. The current implementation dates back from the time where my metaprogramming skills where virtually nonexistent. I am now planning a more powerful @indexnotation macro. The next few weeks will however be very busy so I am not gonna make any promises regarding release date.

@garrison
Copy link
Contributor

Awesome! Glad to hear. I look forward to kicking the tires once you're happy.

@pgawron
Copy link

pgawron commented Oct 5, 2015

When can we expect TensorOperations.jl to be compatible with julia 0.4.0 ?

@Jutho
Copy link
Owner

Jutho commented Oct 5, 2015

The code under the branch staged works on julia 0.4.0 and offers various improvements. See also WIP in the pull requests. The only remaining thing is updating the documentation but I won't have much time this week.

@Jutho Jutho closed this as completed Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants