Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fréchet distance #155

Open
Kolaru opened this issue Jan 13, 2020 · 6 comments
Open

Fréchet distance #155

Kolaru opened this issue Jan 13, 2020 · 6 comments

Comments

@Kolaru
Copy link

Kolaru commented Jan 13, 2020

I have an (yet untested) implementation of discrete Fréchet distance between curves that I would be happy to share. Is this package a good fit for such kind of distances ? I'm wondering as for what I see all distances defined up to now are distances between vectors.

If it's deemed a good fit, I'll propose a PR.

@nalimilan
Copy link
Member

I'm not familiar with the Fréchet distance, but if you can make it fit in the existing framework, then sure.

I'm wondering as for what I see all distances defined up to now are distances between vectors.

What do you mean? What kind of object would your function take?

@Kolaru
Copy link
Author

Kolaru commented Jan 15, 2020

Discrete Fréchet distance is a distance between polygonal curves, so the input would be lists of points (or rather matrices where each column corresponds to a point). So it wouldn't add any dependency but may make internal broadcasting rules for pairwise and colwise significantly more complex (if kept as generic as possible).

@nalimilan
Copy link
Member

Mmm, that sounds like a much more ambitious change then. Maybe develop this in another package first. Are there other similar distances that would use the same framework?

@Kolaru
Copy link
Author

Kolaru commented Jan 15, 2020

After doing some reasearch it looks like there is not many other metrics between polygonal curves/object represented by matrices. So there isn't much need for a generic interface as far as I can see.

I'll go for a separate package first as you suggest I think.

@captchanjack
Copy link

Hi @Kolaru did you end up create that package for Fréchet distance? Keen to see your implementation as I'm looking for something I can use in my application to compare lines

@Kolaru
Copy link
Author

Kolaru commented Sep 13, 2021

@captchanjack You can find my implementation there https://github.com/Kolaru/FrechetDistance.jl.

I did not end up using it very much, so I haven't spend much time optimizing or testing it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants