Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

promote_type involving NAtype doesn't seem right #134

Open
garborg opened this issue Jan 3, 2015 · 1 comment
Open

promote_type involving NAtype doesn't seem right #134

garborg opened this issue Jan 3, 2015 · 1 comment

Comments

@garborg
Copy link
Member

garborg commented Jan 3, 2015

(As mentioned a comment near the promote_type definition, but deserves an issue.)

Came up on julia-users: https://groups.google.com/forum/#!topic/julia-users/piCb9m7lUmE

Breaking vcat(dfs) when a column of NAtype and another type T are vcat'ed:

x = similar(promote_type(...), ...) # is of type `T`
x[i] = NA # fails to convert to type T

Not expecting immediate action because of the other work going on, but putting it up here.

@johnmyleswhite
Copy link
Member

Never been too happy with how we defined promote_type, but agree that it's a low priority when we're shifting to Nullable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants