Accept multidimensional arrays as input #55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=======================================
Coverage 62.81% 62.81%
=======================================
Files 8 8
Lines 589 589
=======================================
Hits 370 370
Misses 219 219
Continue to review full report at Codecov.
|
|
Thank you for improving all the obsolete overtyping @antoine-levitt :) |
|
Not sure, that depends on whether concrete types in structs are important or not. An alternative is to force static typing by using parametric types, but there must be a downside to doing that and just parametrizing the type of every field in a struct, otherwise why would anybody ever do anything else? |
|
I was thinking in terms of using, for example, AbstractArray? Would that
make a difference for performance? I'm happy with Array, just wondering.
…On Sun, 25 Jun 2017, 21:35 Antoine Levitt, ***@***.***> wrote:
Not sure, that depends on whether concrete types in structs are important
or not. An alternative is to force static typing by using parametric types,
but there must be a downside to doing that and just parametrizing the type
of every field in a struct, otherwise why would anybody ever do anything
else?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFV6DdcU41gU8HTDLg4Vf63Et3e6cxi5ks5sHsSogaJpZM4OEp-1>
.
|
|
The API is wrong in any case, because linesearch should only see, well, line searches and the API should be rewritten, so this conversation is best had at the Optim level (see JuliaNLSolvers/Optim.jl#399) |
Simple vector->array. I also typed everything to T for consistency.