Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial HagerZhang: norm(gr) -> norm(gr)^2 #133

Closed
mohamed82008 opened this issue Oct 31, 2018 · 6 comments · Fixed by #136
Closed

Initial HagerZhang: norm(gr) -> norm(gr)^2 #133

mohamed82008 opened this issue Oct 31, 2018 · 6 comments · Fixed by #136

Comments

@mohamed82008
Copy link
Contributor

LineSearches.jl/src/initialguess.jl

Line 292 in 1f40bf3

alpha = psi0 * abs(f_x) / norm(gr)

In the paper, the divisor is norm(gr)^2
@mohamed82008
Copy link
Contributor Author

Should also check against alphamax.

@mohamed82008 mohamed82008 mentioned this issue Oct 31, 2018
Closed
@pkofod
Copy link
Member

pkofod commented Oct 31, 2018

Happy to accept bug fixes

@pkofod
Copy link
Member

pkofod commented Oct 31, 2018

In general a if you can provid a line number and an equation number from the paper or line in the reference implementation (wherever you checked) review will be much faster. Thanks

@mohamed82008
Copy link
Contributor Author

Oh my bad sorry. This is from initialization step I0-b page 12.

@mohamed82008 mohamed82008 mentioned this issue Nov 1, 2018
Merged
@pkofod
Copy link
Member

pkofod commented Nov 1, 2018

Oh my bad sorry.

I hope you didn't read it in an annoyed voice, I just wanted to say that it's much more likely that I can quickly reply if I have both line numbers (as you provided!) and equation numbers :) (got to remember those smileys ;) )

@mohamed82008
Copy link
Contributor Author

No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Fix HagerZhang bugs mohamed82008/LineSearches.jl
2 participants
@pkofod @mohamed82008