From 64f04145cadf0f78db558b9cde86a9b329a93431 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Asbj=C3=B8rn=20Nilsen=20Riseth?= Date: Tue, 5 Jun 2018 09:17:24 +0200 Subject: [PATCH] Don't filter example tests based on environment. (#116) Travis, AppVeyor, and CIBot all fail when there are breaking changes between LineSearches and downstream packages, such as Optim, that are also used in the examples. Instead of filtering tests based on CI environment, we'll just have to remember to add the tests back when the most recent downstream application works. --- docs/generate.jl | 11 +++-------- test/examples.jl | 11 +++-------- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/docs/generate.jl b/docs/generate.jl index 13a97ed..b5262e6 100644 --- a/docs/generate.jl +++ b/docs/generate.jl @@ -1,14 +1,9 @@ # generate examples import Literate -# We shouldn't run the examples that require Optim in Travis/CI, -# because an update in LineSearches may be breaking with the -# most recently tagged Optim version. -if get(ENV, "CI", "") == "true" - ONLYSTATIC = ["optim_linesearch.jl", "optim_initialstep.jl"] -else - ONLYSTATIC = ["",] -end +# TODO: Remove items from `SKIPFILE` as soon as they run on the latest +# stable `Optim` (or other dependency) +ONLYSTATIC = ["optim_linesearch.jl", "optim_initialstep.jl"] EXAMPLEDIR = joinpath(@__DIR__, "src", "examples") GENERATEDDIR = joinpath(@__DIR__, "src", "examples", "generated") diff --git a/test/examples.jl b/test/examples.jl index 5e5af98..548a173 100644 --- a/test/examples.jl +++ b/test/examples.jl @@ -1,12 +1,7 @@ @testset "Literate examples" begin - # We shouldn't run the examples that require Optim in Travis/CI, - # because an update in LineSearches may be breaking with the - # most recently tagged Optim version. - if get(ENV, "CI", "") == "true" - SKIPFILE = ["optim_linesearch.jl", "optim_initialstep.jl"] - else - SKIPFILE = ["",] - end + # TODO: Remove items from `SKIPFILE` as soon as they run on the latest + # stable `Optim` (or other dependency) + SKIPFILE = ["optim_linesearch.jl", "optim_initialstep.jl"] EXAMPLEDIR = joinpath(@__DIR__, "../docs/src/examples")