Fix Base.StackTraces.lookup(C_NULL - 1) on macOS 12 #43612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2021
|
Hmm, seems like this breaks some legitimate symbols on Linux. Am I missing an "obviously correct" way (i.e. documented dladdr behaviour) to solve this issue on aarch64-darwin? |
|
Seems like other people also found this: https://www.mail-archive.com/[email protected]/msg39078.html |
See comment in diff for explanation. This fixes test/stacktraces.jl on aarch64 macOS 12, and according to an OpenJDK issue where they ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193, probably also x86_64 macOS 12.
dnadlinger
force-pushed
the
aarch64-darwin-invalid-stacktraces
branch
from
343d202 to
5e35ff7
Compare
dnadlinger
changed the title
|
This seems fine to me, but I'd like @vtjnash to weigh in as well. |
|
Implemented the explicit check for -1, and updated the above description. Only -1 shows this weird behaviour, the lookup for -2 fails as expected. Unfortunately, the latest dyld hasn't been open-sourced yet, so there is no way to verify what's going on save for decompiling dyld. |
vchuravy
added
backport 1.7
backport 1.6
KristofferC
pushed a commit
that referenced
this pull request
Jan 10, 2022
See comment in diff for explanation. This fixes test/stacktraces.jl on aarch64 macOS 12, and according to an OpenJDK issue where they ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193, probably also x86_64 macOS 12. (cherry picked from commit 7f27dea)
23 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jan 10, 2022
See comment in diff for explanation. This fixes test/stacktraces.jl on aarch64 macOS 12, and according to an OpenJDK issue where they ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193, probably also x86_64 macOS 12. (cherry picked from commit 7f27dea)
50 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
See comment in diff for explanation. This fixes test/stacktraces.jl on aarch64 macOS 12, and according to an OpenJDK issue where they ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193, probably also x86_64 macOS 12.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
See comment in diff for explanation. This fixes test/stacktraces.jl on aarch64 macOS 12, and according to an OpenJDK issue where they ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193, probably also x86_64 macOS 12.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
See comment in diff for explanation. This fixes test/stacktraces.jl on aarch64 macOS 12, and according to an OpenJDK issue where they ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193, probably also x86_64 macOS 12. (cherry picked from commit 7f27dea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment in diff for explanation. This fixes test/stacktraces.jl on aarch64 macOS 12, and according to an OpenJDK issue where they ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193, probably also x86_64 macOS 12.