Something wrong with sum?

[IainNZ]

Quite a few packages broke last night with the following error:

ERROR: sum_impl not defined
 in _sum! at reducedim.jl:145
 in sum at reducedim.jl:166
 in sum at reducedim.jl:174
 in levenberg_marquardt at /home/idunning/pkgtest/.julia/v0.3/Optim/src/levenberg_marquardt.jl:57
 in curve_fit at /home/idunning/pkgtest/.julia/v0.3/Optim/src/curve_fit.jl:15
 in include at boot.jl:244
 in anonymous at no file:26
 in include at boot.jl:244
 in include_from_node1 at loading.jl:128
while loading /home/idunning/pkgtest/.julia/v0.3/Optim/test/curve_fit.jl, in expression starting on line 9
while loading /home/idunning/pkgtest/.julia/v0.3/Optim/test/runtests.jl, in expression starting on line 24
INFO: Package database updated

[IainNZ]

🍺 for you and a 🍺 for PackageEvaluator

[tkelman]

And how. PackageEvaluator should run on all pull requests!

Kidding... kind of.

[IainNZ]

Would be nice to have little buttons on a PR, so right before submitting you can run a perf test (on a standardized machine) and PkgEval

[pao]

I believe some projects have used GitHub bots and parsed comments with special syntax, for instance @JuliaPkgEval test(PackageOne, Package2) perf.

If you do this, please allow an optional "please" after the username so we can be polite to the bot.

[simonster]

It would also be nice to have code coverage reports for Base. @IainNZ have you already attempted this?

[IainNZ]

I think --code-coverage deliberately ignores Base so I'd need to go dig into the internals and expose that as a switch, perhaps.

[simonster]

It might also be problematic that the tests run in parallel.