Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allocation profiler not threadsafe #44099

Closed
vilterp opened this issue Feb 9, 2022 · 1 comment · Fixed by #44116
Closed

allocation profiler not threadsafe #44099

vilterp opened this issue Feb 9, 2022 · 1 comment · Fixed by #44116
Assignees
@vilterp
Labels
multithreading Base.Threads and related functionality
Milestone
1.8

Comments

@vilterp
Copy link
Contributor

vilterp commented Feb 9, 2022 •
edited by NHDaly
Loading

@vtjnash pointed out this thread safety bug not caught by our tests: #42768 (comment)

This can result in multiple threads corrupting the stack traces from each others' allocs, leading to a corrupted profile.

Fix involves keeping a buffer per thread.
EDIT: And/or maybe reusing the existing backtrace buffer in the ptls object. (See the linked thread, above)

cc @NHDaly
@vilterp vilterp mentioned this issue Feb 9, 2022
Merged
7 tasks
@Sacha0
Copy link
Member

Sacha0 commented Feb 9, 2022

(Assigned to Pete at Pete's request :).)

This was referenced Feb 10, 2022
Closed
Merged
@vchuravy vchuravy added this to the 1.8 milestone Feb 15, 2022
@JeffBezanson JeffBezanson added the multithreading Base.Threads and related functionality label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vilterp vilterp

Labels
multithreading Base.Threads and related functionality
Projects
None yet
Milestone
1.8
4 participants
@vilterp @vchuravy @JeffBezanson @Sacha0