Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hcat is not type-stable for sparse matrices #19304

Closed
stevengj opened this issue Nov 11, 2016 · 2 comments
Closed

hcat is not type-stable for sparse matrices #19304

stevengj opened this issue Nov 11, 2016 · 2 comments
Labels
sparse Sparse arrays types and dispatch Types, subtyping and method dispatch

Comments

@stevengj
Copy link
Member 

julia> Base.Test.@inferred hcat(sparse(rand(3,4)) , eye(3,3))
ERROR: return type SparseMatrixCSC{Float64,Int64} does not match inferred return type Union{Array{Any,1},SparseMatrixCSC{Tv,Ti<:Integer}}
@stevengj stevengj added sparse Sparse arrays types and dispatch Types, subtyping and method dispatch labels Nov 11, 2016
@Sacha0
Copy link
Member

Sacha0 commented Nov 11, 2016

Ouch. In case someone looks into this in the near term, chances are the relevant code is here. Best!

@stevengj stevengj mentioned this issue Nov 11, 2016
Merged
@pabloferz
Copy link
Contributor

Part of the problem is the same as #19038, that is, cat_t is no type stable and needs to be almost rewritten from scratch to fix it.

@pabloferz pabloferz mentioned this issue Nov 23, 2016
Merged
@stevengj stevengj closed this as completed Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sparse Sparse arrays types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevengj @Sacha0 @pabloferz