use unsafe_string instead of bytestring

[wookay]

It was a closed issue but to fix the potential problem.
#443

[wookay]

reviewing with JuliaInterop/ZMQ.jl#109

[wookay]

it's planning for ZMQ.jl versions JuliaInterop/ZMQ.jl#110

[tkelman]

is this fixing a deprecation warning or an error? if it's just fixing a deprecation warning, it's too tight

[wookay]

this should be ZMQ 0.3.4.
it's been changed with unsafe_string(::Message) since ZMQ 0.3.3,
but ZMQ 0.3.3 has wrong(conditional deprecation).

[tkelman]

It works, it just has a lot of warnings. I suspect versions earlier than 0.3.1 would work too without any errors, wouldn't they?

[wookay]

I mean, for Julia 0.4, ZMQ 0.3.1 was defined for the type Message with

bytestring(zmsg::Message) = bytestring(pointer(zmsg), length(zmsg))

and with this PR, calling unsafe_string(::Message) doesn't work on Julia 0.4.

when running jupyter-notebook, there's hanging with timeout like this

[W 21:35:58.097 NotebookApp] Timeout waiting for kernel_info reply from e3f8da4c-ce1c-4604-965e-200479992642

thanks.

[tkelman]

Ah, that makes sense, there was no unsafe_string(::Message) method before ZMQ.jl 0.3.3? So ZMQ.jl 0.3.3 is the actual minimum.

[wookay]

that's also bad, because there's the critical issue for on ZMQ 0.3.3.
JuliaInterop/ZMQ.jl#108 (comment)
incidentally causing lot's of deprecated warnings for every input on IJulia.
I prefer to use ZMQ 0.3.4.

[tkelman]

The requirements of ZMQ 0.3.3 and 0.3.4 are the same, so any time both are possible, Pkg will use the larger of them.

[stevengj]

Bump. Needs a rebase and updated REQUIRE to ZMQ 0.3.3

[wookay]

ok. I'm going to rebase to ZMQ 0.3.3

[stevengj]

Thanks.